Design comparison
SolutionDesign
Solution retrospective
I learned how to use grids 🔥 🔥 with this project and I enjoyed building it, any feedback is appreciated 👍.
Community feedback
- @dusanlukic404Posted about 3 years ago
Hey Rami, well done! You did very good job.
- Set display flex to body and also height of 100vh so you can easily center your main card
- Then set overflow to hidden so you won't see vertical scrollbar
- Make button more visible with box-shadow
- Don't use <h2> instead of <h2>. You should think about it semantically. <h1> should come before <h2> in a document. <h2> is a sub element of <h1>.
Marked as helpful1 - @palgrammingPosted about 3 years ago
Looks good you are just missing your shadow around your layout
Marked as helpful0@Daniels-notPosted about 3 years ago@palgramming Thanks for your feedback 🔥.
0 - @afrusselPosted about 3 years ago
Your main container is not center align both vertical and horizontal. Use display flex, align-item center and others
1@Daniels-notPosted about 3 years ago@afrussel Thanks for your feedback 🐻.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord