Design comparison
Solution retrospective
Feedback Please :D
Community feedback
- @nikea1Posted over 2 years ago
Hello topspinppy! I think you did an excellent job with the card so far.
Just a few things I noticed. First, I think you need to fix the text color, you can't really see it or read it easily. When styling text it's important the text colors and the background colors have enough contrast for readability. I believe one of the files that's downloaded with the challenge called style-guide.md has the colors needed so you can just copy and paste them in your style sheet where needed.
Second is just some html formatting. So, in the <html> tag, it's best practice to add a lang to declare the language of the document. Since it's in English you put in lang="en". In the image tag you don't need to specify units for the size for height and width. It's already in pixels and <img> will only use pixels. Just the number itself is fine.
Finally, there accessibility. So, I just learned this myself recently. You just need to use a <main> tag around your content and use <h1> tag somewhere at the beginning of your content.
I think that's about it. I wish you luck! :)
2 - @topspinppyPosted over 2 years ago
Thanks You can feedback more about css because I want to practice :D
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord