Submitted over 2 years ago
Proyecto 1 - Frontend Mentor, Codigo QR
@HernandoSilvaLeal
Design comparison
SolutionDesign
Solution retrospective
Hola amigos, espero seguir avanzando con toda, tuve inconvenientes para poder elegir la tipografia exacta, ya que no tuve el mockup de figma, sin embargo intente que quedase lo mas similar posible, muchas gracias por este espacio y รกnimo a todos!
Community feedback
- @denieldenPosted over 2 years ago
Hi Hernando, I took some time to look at your solution and you did a great job!
Also I have some tips for improving your code:
- use
main
tag and wrap the card for Accessibility and notnav
because nav is for navigation - remove all unnecessary code, the less you write the better as well as being clearer: for example the
br
- instead of using
px
try to use relative units of measurement -> read here
Overall you did well :)
Hope this help and happy coding!
0 - use
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord