Prototyped in Figma, used HTML and CSS Flexbox

Community feedback

• 

  mohamed farid•580

  @FaridJuniorPosted almost 4 years ago

  Hello Eskender 👋

  it is very good 🔥, and it is responsive plus your work in Figma is very good, I read the code and I think it is better to give the container percentage, not static values. For example on-screen with a width of 400px it will leave un-nice space on both sides.

  The shadow is very strict, try to make it more smooth, try this shadow generator it will take some time to get familiar with but it very nice.

  keep going 😊

  4

  ---

  

  Eskender•65

  @egxperiencePosted almost 4 years ago

  @mohamedfarids Thank you for the feedback Mohamed. Actually it took more than expected for this (basic) project and used exact px values to fit the 'media' settings. Didn't tried percentage as won't sure on how it can react to the settings, but definitely will check it soonest. Additional thanks for feedback regarding Figma - this is my first try so all will come with experience:)

  1

  

  mohamed farid•580

  @FaridJuniorPosted almost 4 years ago

  @egxperience

  you are welcome😁 totally agree with you, all will come with experience.

  0
• 

  T

  Grace•31,270

  @grace-snowPosted almost 4 years ago

  Hi there

  This looks very close to the design now you've fixed the color of the why section, well done

  The only odd thing is the large space at the top of the screen on mobile for me, and that's caused by using explicit pixel values.

  In future challenges I'd definitely recommend you use fewer media queries and don't set widths and heights on elements. You can use things like flexbox to center content as needed, with a little padding or margin on that container. If you do mobile styles first and use properties like max-width you shouldn't need lots of media queries, maybe just one or two if the layout needs to change a lot as the screen size grows.

  Best of luck with it

  1