Proper Styling Using CSS: Cleanliness of the Code

Community feedback

• 

  Ed-dyb Abdelilah•1,560

  @eddybproPosted over 1 year ago

  Hi, CocoShesh

  Congratulation on finishing this challenge, I hope it was fun.

  For code here are some suggestions that might help improve the code:

  • HTML code:

  <div class="star-container">  </div>
  

  • CSS code:

  main{
  */ remove the scrollbar in big screen*/
  overflow: hidden;
  }
  .best-tech{
  padding-left:.25rem;
  }
  .star-container {
  width: 6.25rem;
  height: 1rem;
  display: flex;
  justify-content: center;
  background: url(./images/icon-star.svg);
  background-position: center;
  background-repeat: space;
  }
  

  Tip

  The value of the property font-whight does not have a unit.

  If the value of margin, padding is 0 you don't have to add a unit.

  -Examples:

  h1{
  font-whight:700;
  

  p{
  padding-top:0;
  

  I hope my suggestions were helpful.

  Happy coding

  Marked as helpful

  0

  ---

  

  CocoShesh•160

  @CocoSheshPosted over 1 year ago

  @eddybpro Thank you so much for your kind words and congratulations! I really appreciate your encouragement.

  The challenge was indeed a lot of fun, and I'm thrilled to have completed it successfully.

  I'm grateful for your suggestions to improve the code. Modularity sounds like a great idea, and I'll definitely work on breaking down the code into smaller, reusable functions or modules. This will make it easier to manage and maintain in the long run.

  0
• 

  Domilson Firmino•360

  @DomilsonFirminoPosted over 1 year ago

  my advices go to the way you spaced your section with class main, it already as flex, you could give it a justify-content: space-between property, it would space itself and you would not need to space it with margin-left;

  And you main tag could use a container class; to limit the space of the design , because you layout tend to have a scrow bar in big screen, I hope it was helpful to you

  Marked as helpful

  0

  ---

  

  CocoShesh•160

  @CocoSheshPosted over 1 year ago

  @DomilsonFirmino Thank you for reaching out and sharing your comment. I value your feedback and appreciate your input.

  0