Project using HTML and CSS | FlexBox

Community feedback

• 

  Francisco Carrillo•5,540

  @frank-itachiPosted over 1 year ago

  Hello there 👋. You did a good job!

  I have some suggestions about your code that might interest you.

  HTML 📄:

  • The heading order is important in the html structure so try to always start your headings and/or titles with an <h1> tag and then you can decrease by one if you need to use more headings in your html code.

  CSS🎨:

  You can use grid or flexbox to center the content no matter the viewport size. Since I use grid to achieve such purpose, you can do the following:

  body {
  min-height: 100vh;
  display: grid;
  align-items: center;
  justify-content: center;
  }
  

  As I said, you can use flexbox to center the content and it will work as well.

  body {
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
  }
  

  • Avoid using absolute length units px, especially for font-size and width properties, because they are not relative to anything else so that means they will always be the same size. Instead, you can use relative lengths like em or rem. The benefit of that last one is element which has that unit will scale relatively to everything else within the page, e.g., the parent container. You can dig up about it here

  I hope you find it useful! 😁😁 Above all, the solution you submitted is great👌!

  Happy <coding /> 😎!

  Marked as helpful

  1
• 

  Abdessamad•210

  @styrexxPosted over 1 year ago

  Hello there 👋. You did a good job!

  There are a few changes you can make to make your solution better.

  • Fix the issues that have been reported.

  • You can use a grid to center the content no matter the viewport size. You can do the following:

  body {
  	min-height: 100vh;
          display: grid;
  	align-items: center;
  	justify-content: center;
  }
  

  • Fix the issues that have been reported.

  I hope you find this helpful.

  Marked as helpful

  1