Project Tracking Intro Component master using HTML & CSS

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted almost 5 years ago

  Hey Liny, nice work on this challenge! You've done a really good job on the responsive side of this project. One small issue is that if I open and close the navigation on mobile and then increase the screen size to desktop the navigation doesn't reappear. Have a look into that and see if you can resolve it. If you're struggling to find the answer let me know and I'll tell you what's going on. Also, don't forget to fix the accessibility issues! 🙂

  0

  ---

  

  Liny Thomas•185

  @LinyThomasPosted almost 5 years ago

  @mattstuddert , Thanks a lot for taking time to review my code and giving your feedback.I have tried to fix the navigation display issue by adding the below jquery. $( window ).resize(function() { if($(window).width()>700) $('#menu').show(); else $('#menu').hide(); });

  Please let me know if this code is sufficient or let me know if there is a better way to resolve this. I have corrected the accessibility issues but the anchor links are still giving error as I have not used a valid href and I am using this as a pseudo button. <a href="#" class="icon" onclick="myFunction()"> <i class="fa fa-bars...</a> Thank you for your help. Liny

  0

  

  T

  Matt Studdert•13,611

  @mattstuddertPosted almost 5 years ago

  @LinyThomas yeah, that works fine 👍

  The accessibility errors on the anchor tags are showing up because there is currently no text inside the anchor tags to describe what the link is for. This means people who use screen readers might not know why they should click the link. You could either add text inside and hide it visually, or add an aria-label attribute to the anchor tags like this <a href="#" aria-label="Open menu">.

  0

  

  Liny Thomas•185

  @LinyThomasPosted almost 5 years ago

  @mattstuddert , I have added the aria label attribute to the anchor tags and now the accessibility issues are fixed. Thanks once again,Liny

  0