Project tracking intro component (Flexbox, Grid, SCSS)

Community feedback

• 

  Rafael Maia Chieregatto•320

  @rafaelmaiachPosted almost 5 years ago

  Hey Patrick, congrats on your solution.

  About the design question, you could set a max-width for your container. As you already is setting margin: 0 auto, when you define the max-width property, you will have your content centered on screen to a max size you define

  2

  ---

  

  Patrick Touchette•355

  @patricktouchettePosted almost 5 years ago

  @rafaelmaiach Hi rafael, thats a good idea and it usually works, however given how the image is cut off on the side it looks odd having some whitespace to the right of the image. Seems to me it needs to be on the edge of the screen. Hmm, i did a test with a max-width: 1440px, and margin-right: 0 on the .wrapper, and take just brings it all to the right. Not sure if that looks good though.

  0

  

  Rafael Maia Chieregatto•320

  @rafaelmaiachPosted almost 5 years ago

  Yeah, I thought about the image looking like is cut off, but Maybe if you propagate that gray color to the right, instead leaving white, could help? I'll send this solution and question to Matt, maybe he can give us some tips about it

  0

  

  T

  Matt Studdert•13,611

  @mattstuddertPosted almost 5 years ago

  Hey guys, I agree with @rafaelmaiach about the container but I also see your point @patricktouchette about the image being cut off. This was an oversight on my part! I've actually updated the image for the challenge now, which you can grab from here if you like.

  I need to get myself an ultra-widescreen so I can pick up on these things sooner! 😅

  1

  

  Patrick Touchette•355

  @patricktouchettePosted almost 5 years ago

  @mattstuddert Thanks! I added in a media query for 1920px to switch to that updated image. This makes me realize it's hard to work with a split image on the side. Definately upgraded my skills hehe.

  Ultra-wide is awesome, you won't regret!

  Cheers

  0