Project tracking intro component

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted almost 5 years ago

  Nice work, Felix and it's great to hear that you're starting to feel more confident with CSS. The major issue with how you've implemented the mobile dropdown is that it's not accessible to people who can't use a mouse/trackpad. You're using a click event on a div to trigger the menu. div elements are not interactive elements, so it's a bad practice to have click listeners on them, as it creates inaccessible functionality. Instead, use an interactive element like a button to trigger the menu dropdown. If you want to see an example, take a look at the mobile version of Frontend Mentor and see how the mobile navigation works.

  Keep it up!

  1

  ---

  

  Felix Anducho•400

  @PleopleqPosted almost 5 years ago

  @mattstuddert As always a great piece of advice, thanks Matt!

  0
• 

  Carlos Fins•145

  @clockwerkzPosted almost 5 years ago

  Looking good! All of the elements are in the right spots.. My only note is that the the content on the left should all be left aligned, like in the design image. Other than that it's looking good!

  1

  ---

  

  Felix Anducho•400

  @PleopleqPosted almost 5 years ago

  @clockwerkz Thank! And yes, a little problem with the spaces that i just noticed

  1