Skip to content
Submitted about 2 years ago

Project Tracking Intro coded w/HTML SCSS JS

birkaany•240
@birkaany
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Project tracking intro component
  • HTML
  • CSS
  • JS
2junior

Design comparison

SolutionDesign

Solution retrospective

This project needed a bit more time to complete yet I've learnt a lot while doing it.

I tried changing navigation menu's style for mobile and hide it until hamburger menu button being clicked. I thought this is a better solution than creating whole new menu but I'd like to hear few feedback about this.

Community feedback

  • Adriano•38,390
    @AdrianoEscarabotePosted about 2 years ago

    Hi birkaany, how are you?

    I really liked the result of your project, but I have some tips that I think you will like:

    1- Every page should have one main landmark <main>. So replace the div that wraps the whole content with <main> to improve the accessibility. click here

    2- All page content should be contained by landmarks, you can understand better by clicking here: click here

    We have to make sure that all content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.

    Example:

    native HTML5 reference elements:

    <body>
    <header>This is the header</header>
    <nav>This is the nav</nav>
    <main>This is the main</main>
    <footer>This is the footer</footer>
</body>

    ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:

    <body>
     <div role="banner">This is the header</div>
     <div role="navigation">This is the nav</div>
     <div role="main">This is the main</div>
     <div role="contentinfo">This is the footer</div>
</body>

    It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.

    Link to read more about: click here

    2- Why it Matters

    Navigating the web page is far simpler for screen reader users if all of the content splits between one or more high-level sections. Content outside of these sections is difficult to find, and its purpose may be unclear.

    HTML has historically lacked some key semantic markers, such as the ability to designate sections of the page as the header, navigation, main content, and footer. Using both HTML5 elements and ARIA landmarks in the same element is considered a best practice, but the future will favor HTML regions as browser support increases.

    Rule Description

    It is a best practice to ensure that there is only one main landmark to navigate to the primary content of the page and that if the page contains iframe elements, each should either contain no landmarks, or just a single landmark.

    Link to read more about: click here

    Prefer to use rem over px to have your page working better across browsers and resizing the elements properly

    The rest is great!!

    Hope it helps...👍

    Marked as helpful
    0
    birkaany•240
    @birkaanyPosted about 2 years ago

    @AdrianoEscarabote Hello Adriano, I wasn't aware of such difficulties and I'm kinda ashamed. I dived right into this after a tiny research. Thank you so so much for enlightening me about this.

    1
    Adriano•38,390
    @AdrianoEscarabotePosted about 2 years ago

    @birkaany happy coding!!

    0
  • Sahand Masoleh•1,210
    @sahand-masolehPosted about 2 years ago

    Merhaba Birkan bey!

    There's nothing wrong with creating a new element for the mobile menu, do it however you are comfortable as long as accessibility practices are exercised. For example right now your hamburger button is actually a picture element with a click event listener, and that's not good for accessibility. Try to use a button tag instead which is selectable and clickable natively.

    Also, if open, your mobile menu doesn't close when the view expands beyond your break-point. This means that if a user opens the menu and then turns the phone into landscape mode, they will still see the mobile menu with no way of closing it.

    Marked as helpful
    0
    birkaany•240
    @birkaanyPosted about 2 years ago

    @sahand-masoleh I'm planning to research about a proper way of doing this type of menu, I just didn't wanna watch/read before I code it myself to see If I can do it. I definitely will fix those issues.

    Also, accessibility is just another important topic that I have to study. Thank you for helping me!

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord