Design comparison
Solution retrospective
Give some feeback
Community feedback
- @Harsh-Kumar-DwivediPosted 8 months ago
Hi @HansKevin,
Nice Solution !
I would suggest following:-
1.Prefer using
<main>
element instead of<div class="container">
.2.Consider replacing
<div class="attribution">
with<footer>
element.3.Providing fallback fonts are useful.
4.In this project, I think it is not useful to select
container
class as a part of CSS rule selector every time.5.Understanding CSS rule selector specificity could be helpful.
These will enhance your code, improve accessibility and make your markup more semantic.
Hope these suggestions are helpful !
Stay Happy & Well !
Happy Learning !
Marked as helpful0@Harsh-Kumar-DwivediPosted 8 months ago@HansKevin
Welcome !
Keep up the good work !
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord