Harsh Kumar Dwivedi• 740
@Harsh-Kumar-Dwivedi
Posted
Hi @HansKevin,
Nice Solution !
I would suggest following:-
1.Prefer using <main> element instead of <div class="container">.
2.Consider replacing <div class="attribution"> with <footer> element.
3.Providing fallback fonts are useful.
4.In this project, I think it is not useful to select container class as a part of CSS rule selector every time.
5.Understanding CSS rule selector specificity could be helpful.
These will enhance your code, improve accessibility and make your markup more semantic.
Hope these suggestions are helpful !
Stay Happy & Well !
Happy Learning !
Marked as helpful
0
HansKevin• 40
@HansKevin
Posted
@Harsh-Kumar-Dwivedi thanks
1
Harsh Kumar Dwivedi• 740
@Harsh-Kumar-Dwivedi
Posted
@HansKevin
Welcome !
Keep up the good work !
0
