profile-card-component-main-Solution

Community feedback

• 

  Thomas Hertog•825

  @thomashertogPosted over 3 years ago

  try fixing the issues in the report first

  other than that -> try to think real good about the semantics in your HTML e.g. the numbers aren't really headers + they should somehow be linked to their label so users with assistive technology don't miss out on this as well

  Marked as helpful

  1

  ---

  

  Youssef Ali•35

  @youssefali715Posted over 3 years ago

  @thomashertog Thanks bro🌹

  0
• 

  Katie•405

  @kem522Posted over 3 years ago

  Great work! I didn't know space-evenly was a flex property before so learnt something new today.

  In your CSS everytime you target the followers class you have container before it. Since you only have one element with the class followers you don't need to add the extra level of specificity since all the styles are only going to be applied to that one element.

  If you had say this HTML:

  <div class="container">
    <div class="followers"></div>
  </div>
  
  <div class="wrapper">
   <div class="followers"></div>
  </div>
  

  Then if you only wanted to apply styles to the first followers div you would need to add .container beforehand.

  Also, you have multiple rule blocks for the same element, you. have .container .followers twice:

  .container .followers {
      display: flex;
      align-items: center;
      justify-content: space-evenly;
  }
  // ...
  .container .followers{
      margin-bottom: -25px;
  }
  
  // instead you could just have one with all the styles
  
  .container .followers {
      display: flex;
      align-items: center;
      justify-content: space-evenly;
      margin-bottom: -25px;
  }
  

  Hope that helps!

  Marked as helpful

  1

  ---

  

  Youssef Ali•35

  @youssefali715Posted over 3 years ago

  @kem522 Thanks For Advice 😊

  0