profile-card-component-main

Community feedback

• 

  Adrian H•420

  @AdrianX19Posted almost 3 years ago

  Hi @ahmed9aks,

  Congrats on completing the challenge, nice job! :) I've got a couple of suggestions, maybe you'll find them useful

  • to get rid of your accessibility issues just replace your container <div> with <main> - it's good to get familiar with semantic tags!
  • I see you are using h2 for the name, html tag shouldn't be used to style elements so I would suggest to use h1 and style it to your needs
  • for your footer try to use justify-content: space-around, that will give you result closer to the designs
  • you've got small typo in your CSS inside the media quries: padding: 145px, 25px; the values should not be separated with the comma

  Marked as helpful

  0

  ---

  

  Ahmed•80

  @ahmed9aksPosted almost 3 years ago

  @AdrianX19 Thanks a lot for the feedback Adrian. I'll make sure to take advantage of every opportunity I get. This is free college/university education right here. Sir, you're phenomenal and your feedbacks are always welcome. Cheers and best of luck

  0