Skip to content
Submitted 9 months ago

Profile-card-component-main

Williamā€¢190
@tuaPuan83
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Profile card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hello. I'm William Klaiwonpen from Bangkok Thailand.

I want to become front-end Developer so If you have any suggestions on how I can improve this project, feel free to leave me a comment!

Feedback welcome šŸ˜Š

Community feedback

  • Daniel šŸ›øā€¢44,250
    @danielmrz-devPosted 9 months ago

    Hello @tuaPuan83!

    Your solution looks great!

    I have a suggestion for improvement:

    • Use <main> to wrap the main content instead of <div>.

    šŸ“Œ Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page.

    This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

    I hope it helps!

    Other than that, great job!

    Marked as helpful
    1
    Williamā€¢190
    @tuaPuan83Posted 9 months ago

    Thank you so much. It's very helpful@danielmrz-dev

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord