@DavidMorgade
Posted
Hello Sohaib, great work with the solution! the layout seems perfect for me and the responsiveness is good, congratulations!
Would like to give you some suggestions regarding your html, since the CSS is good in my opinion and gets the solution correctly.
-
You should try adding a
<main>tag instead of wrapping the whole solution in a<div>, every webpage should have a<main>with all the main content of the page (in this case, it is the whole card). Then you can divide it in semantic<sections>like for example, the stats box could perfectly fit a<section>. -
Also try using and
<h1>instead of a<span>for the username of the card, like the main tag, every page should have an h1 that is the most importante text of the page! -
This are little things that maybe in little projects like this one doesn't matter that much, but is a good practice to start building semantic html files for your future big projects that will need those tags.
-
All of this will improve the accesibility to your page, and will also position it higher on search engines.
Hope my feedback helps you, if you have any questions, don't hesitate to ask! Great work!
Marked as helpful
@muffin50
Posted
@DavidMorgade thank you so much I still have a problem with align content and align-items I'm trying to understand them well. Also thank you for these advices I will try use main tag instead of. And I'll edit this layout too
