profile-card-component-main

Community feedback

• 

  mubizzy•1,520

  @mubizzyPosted over 2 years ago

  Excellent job on this challenge! your report has a few issues though:

  1. wrap everything in your body in <main> or use semantics

  2.   it is a best practice to use both HTML 5 and ARIA landmarks to ensure all     content is contained within a navigational region.

  Hope it helps:)...don't forget to mark it as helpful 👍

  You can get more details here...click here

  Marked as helpful

  1

  ---

  

  Andesa•110

  @AndesaputraPosted over 2 years ago

  @mubizzy still has no clue what landmark is. Thanks for the feedback!

  0
• 

  faizan•2,420

  @afaiz-spacePosted over 2 years ago

  Hey @Andesaputra,

  • Replace height: 100vh; with min-height: 100vh; in the body element. -Remove postion and replace margin-bottom with margin-top in the footer element.

  1