Profile-card-component using HTML CSS

Community feedback

• 

  Ahmed Bayoumi•6,740

  @Bayoumi-devPosted over 2 years ago

  Hey! It looks good!... Here are some suggestions:

  • Page should contain a level-one heading, Change h3 to h1 You should always have one h1 per page of the document... in this challenge, you will use h1 just to avoid the accessibility issue that appears in the challenge report... but don't use h1 on small components <h1> should represent the main heading for the whole page, and for the best practice use only one <h1> per page.
  • I suggest you put the status of the profile card into the list item to add more semantics to your project, Div's don't do much for semantics but a list is much more meaningful..:

  <ul class="stats">
     <li><span class="stats-num">80K</span>Followers</li>
     <li><span class="stats-num">803K</span>Likes</li>
     <li><span class="stats-num"> 1.4K</span>Photos</li>
  </ul>
  

  • Use REM for font size, It is a must for accessibility because px in some browsers doesn't resize when the browser settings are changed... See this article ---> CSS REM – What is REM in CSS?

  I hope this is helpful to you... Keep coding👍

  Marked as helpful

  1
• 

  BanditDev•220

  @banditdev013Posted over 2 years ago

  Hi! Ahmed Bayoumi.

  I thank you very much for your advice. I have already edited this challenge as per your suggestion.

  thanks again 🙂

  0

  ---

  

  Ahmed Bayoumi•6,740

  @Bayoumi-devPosted over 2 years ago

  @banditdev013 You are welcome😊

  0