profile-card-component using grid and margin

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 3 years ago

  👋Hi Adeniyi Smart!

  Put all your CSS on another file. One of the key principle of a good developer is that to completely separate the styling, the markup, and the functionality. Also it makes everyone that see your can understand and read your code much easier.

  For the background-position I would recommend to see a solution from @ApplePieGiraffe since in my opinion this is the best background-position for this challenge.

  For the common reset like this chunk of code and other general styling, put it outside the media query, also you need to choose whether you want to style from desktop first or mobile first.

  * {
    margin: 0;
    padding: 0;
    box-sizing: border-box;
  }
  

  That's it! Hopefully this is useful!

  1