Profile-Card-Component

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Hey there, CypherCode13! 👋

  Congratulations on completing your first Frontend Mentor challenge! 🎉 Nice job on this one! 👏 The card component looks good and you've done a nice job in positioning the background images (which can be a little tricky). 🙌

  I suggest not adding alt text to the background circles in this challenge if you use <img> tags to add them to the site (since screen readers will read out the alt text for those images, then, which isn't necessary since they are mostly just decorative images). 😉

  Also, I think you can use an <article> tag for the card component and make the name inside it a heading to make your HTML a little more semantic (which is good for things like accessibility and SEO).

  Hope those tips help. 🙂

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Vahe Gharagiozyan•230

  @Vahe-SevachyanPosted over 3 years ago

  Hey @ApplePieGiraffe! Thank you so much for those tips, i will definitely keep that in mind and incorporate them into future projects! Happy Coding!

  1

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  @CypherCode13

  Hey, no problem! 👍

  Oh, and BTW, if you found these tips helpful, an upvote would be appreciated! ;)

  1
• 

  Vytas•435

  @vytkuklysPosted over 3 years ago

  Hey CypherCode13, Great job on this challenge. I've noticed that it took you just over 100 CSS lines to write this which is for sure a good example of an efficient code.

  On mobile version it seemed like there could still be an extra line or two used to make your work more adaptable and look better at smaller screen sizes (under 400px).

  It looks good at desktop version, though.

  Hope this helps :) Best of luck!

  1

  ---

  

  Vahe Gharagiozyan•230

  @Vahe-SevachyanPosted over 3 years ago

  @vytkuklys Hey! :) Thank you so much for the feedback, i really appreciate it. I will definitely look into improving on responsive layouts!

  0