Design comparison
Solution retrospective
Hi there, challenge completed any feedback is welcome.
Community feedback
- @beowulf1958Posted about 1 year ago
I checked out your solution because I liked what you did with the background. I struggled with the background, and I like your solution better
Suggestions: first, I noticed that you used a serif font. The challenge called for a Kumbh Sans font in 400 and 700. You have the preconnect google link, but not the link to the actual font: <link href="https://fonts.googleapis.com/css2?family=Kumbh+Sans:wght@400;700&display=swap" rel="stylesheet"> goes in the head section of the html. Also, to increase accessibility you should always include an alt text in an image in order to assist screen readers. Lastly, there are multiple h1 tags, which is a no-no. There should be only one h1 tag per page. H1, h2, etc are not to be used for styling; that is what the CSS is for.
Hope this helps!
0@falloumacbookPosted about 1 year ago@beowulf1958 Thank you so much for your comment, I will try and improve that.❤
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord