profile-card-component

Community feedback

• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, Crespo Maxime! 👋

  Congrats on finishing another challenge! Your solution looks very good and also responds well. Here's my few tips:

  • Add some padding to your .container to prevent your container sticking to borders on smaller screen sizes like 375px iphone6. padding: 0 12px should be enough.
  • Change the alt attributes for the .profile-picture, as it doesn't add any extra context for screen reader users. Since your image is decorative your alt text should be provided empty (alt="") so that they can be ignored by assistive technologies. #name heading is more than enough to describe this, no need to add additional alternative text.

  Good luck with that, have fun coding! 💪

  0
• 

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  yes instead of Background-Size: COVER try maybe 80% you can play around changing setting using Web Developer Tools in the browser really easy

  0