profile-card-component

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted almost 3 years ago

  Hello there, Will! 👋

  I agree that this challenge is challenging, especially to handle those background patterns. I recommend checking out the ApplePieGiraffe solution. He had done a great job of taking care of them.

  Some feedback:

  • Accessibility
    • Alternative text for images should not be hyphenated. Alternative text is a way of the developer to tell the user about the image without actually seeing the image. So, it should informative and meaningful. But, if the image is just for decoration, then you can leave the alt="" empty.
    • I would recommend making Victor Crest 26 London as one sentence by wrapping it with only a h1 because it only makes sense if the text reads as a sentence. You can use span to style each word differently.
    • For the stats, I would recommend using ul instead section and wrapping each stat with li. In addition to that, I would recommend making those numbers a p or span. They are not heading elements for sure.
  • Styling
    • I would recommend removing the min-width property from the body element. Let the body element grow and shrink (responsive). it's the main element of your webpage, so you want to make sure that it's responsive.
    • Don't limit the height of the body element, it will not allow the users to scroll the page if the page content needs more height. Use min-height instead.

  That's it! Hopefully, this is helpful! 😁

  Marked as helpful

  1

  ---

  

  Will•210

  @wkan17012021Posted almost 3 years ago

  @vanzasetia Hi Vanza,

  Thanks for your suggestions. I used your advice for the above and a youtube video for the bubble background to pretty much redo this challenge. I'm happy i did this as i think i learned more and the process was clearer this time round. I've always struggled to appreciate the use cases and often mis-uses of setting width/height, min/max width/height properties (i was told anecdotally to refrain from setting with absolute measurements) especially when there are multiple nested containers. Just something for me to keep practicing on.

  I've updated the readme with yourself in the acknowledgements.

  Thanks again!

  1

  

  Vanza Setia•27,775

  @vanzasetiaPosted almost 3 years ago

  @wkan17012021 Thanks for the attribution! I really appreciate it! 👍

  0