Profile-card

Community feedback

• 

  Faris P•2,810

  @FarisPalayiPosted over 3 years ago

  Good work on this one👍

  • About positioning the background image, using CSS background-image property could make things much easier, and also it is more flexible with the help of related properties like background-position and background-size. Or you could use a CSS pseudo-elements like ::before or ::after for this.
  • Also, those images are purely decorative, so set the alt tag to empty alt="", so that screen readers and other assistive devices can ignore them.
  • Victor's image's alt text shouldn't be "profile-img", it should be something descriptive like Victor's name or something like that.
  • Furthermore, try to clear the issues in the reports section if you can.

  I suggest you to take a look at these articles if you can:

  • HTML: A good basis for accessibility
  • Semantic HTML5 Elements Explained

  I'm not at all an expert in these things, so, do your own research and if there are mistakes on my part, let me know😀

  Have fun coding✨

  Marked as helpful

  1

  ---

  

  Adam.Codes•180

  @AdamCodes42Posted over 3 years ago

  @FarisPalayi Thanks mate 😀 Yes I looked forward to your suggestions and use learned to use pseudo elements and also used in my next solution of storage component and it made easy for me to make the progress bar as the <progress> tag won't get customize.

  I'm also not an expert but by the reviews and suggestions getting improvement day by day.

  visited your side of solution it was great🖤

  Happy coding ✨

  1