Design comparison
Community feedback
- @michel-moreiraPosted almost 2 years ago
Hello Nahal Rahman!
Great job on complete this challenge!
I have some suggestions that might be helpful!
-
You must put a h1 tag on the page cause it should contain a level-one heading, you could replace the p tag referent to the name and maintain the class the same.
-
All you code should be wrapped by
<main></main>
tag landmark; -
To treat a background-image, you could do this in the CSS stylesheet and remove it from the HTML document. With background-image you can manipulate in CSS. An article about it.
-
You've putted the tag
span
, i recommend that you replace it for the tagp
, although it refers to paragraph, it refers either to text; span is a generic tag that has no meaning at all, should be used in few occasions. -
In the class stats you could use a <ul> <li><p> </p></li> </ul> tag with 3 li rather than divs and spans. I hope you find it helpful!
Happy Coding!
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord