Profile Preview Card

Community feedback

• 

  Daniel 👨‍💻•980

  @Daniel-BilodidPosted over 1 year ago

  Hi, my congratulations you did a great job 🎉

  𝐒𝐨𝐦𝐞 𝐭𝐢𝐩𝐬 𝐟𝐨𝐫 𝐲𝐨𝐮𝐫 𝐜𝐨𝐝𝐞 🛠

  🔹 About hr

  You can change your hr to div to make it smaller and decrease the opacity to make it less contrast

  try to do like this

  <div class="hr-div" style=" margin-top: 20px; width: 348px; height: 1px; background-color: black; opacity: 0.2; "></div>

  I hope it was helpful, you are great, keep up the good work 👍

  Marked as helpful

  1
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which lack landmark for a webpage

  ---

  • So fix it by replacing the <div class="main"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  ---

  HEADINGS ⚠️:

  ---

  • And, this solution has also generated accessibility error report due to lack of level-one heading <h1>

  ---

  • Every site must want at least one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

  ---

  BG iMAGE 📸:

  • let me explain, How you can easily apply the background color with the svg they provided.

  ---

  • Add the following style rule to your css, and then experience the changes

  body {
    background: url(./images/bg-pattern-top.svg), url(./images/bg-pattern-bottom.svg);
    background-position: right 52vw bottom 35vh, left 48vw top 52vh;
    background-repeat: no-repeat, no-repeat;
    background-color: hsl(185deg, 75%, 39%);
  }
  

  • Tip, Don't forget to generate a new screenshot after editing the css file

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1
• 

  Satyam Raj•160

  @SatyaaamPosted over 1 year ago

  Bro would you like to tell that how to correctly guess the width and height of frames....

  0

  ---

  

  Daniel 👨‍💻•980

  @Daniel-BilodidPosted over 1 year ago

  @Satreen Hi, if you have a subscription to frontend mentor, they give you a figma design and you can check the width and height

  0
• 

  Satyam Raj•160

  @SatyaaamPosted over 1 year ago

  Thanks bro , I will definitely implement your advise.

  0