profile page

Community feedback

• 

  jan28x•50

  @jan28xPosted 2 months ago

  A few improvements that could be made:

  • it seems you're not linking to the actual picture provided in the assets folder. Try taking the first '.' out of "./assets/images/avatar-jessica.jpeg"
  • the html could be cleaned up a bit. Try moving the

  .attribution { font-size: 11px; text-align: center; }
  .attribution a { color: hsl(228, 45%, 44%); }
  

  in the index.html file to the styles.css file.

  Using an unordered list of links instead of buttons would also be a good idea as the actual site would be used to link the user to the creator's various social media profiles.

  Setting the background colour as the one specified in the style guide would also make the solution closer to the design.

  0

  ---

  

  kunal chugh•30

  @kunal-v2Posted 2 months ago

  Thank you , your suggestion is really insightfull , This was my first time uploading the solution first time so i didnt knew that the image would not show up here , i would have corrected the code but currently i am working on shopify clone ill be uploading it on my github if you wanna se it in future you are most welcome https://github.com/kunal-v2 @jan28x

  0