Profile Component Solution

Community feedback

• 

  Zahidul Islam•20

  @zahid3d29Posted about 2 years ago

  Hey, good design mate. 90+ same design. But, I have suggestions about code.

  Please use the 'p' tag when you have long text content. Otherwise, try to use the 'H' tag for a single text ex: Heading, sub-heading, title, etc. You can use H4, H5, and H6 tags for those 'p' or 'span'. And use "span" tags when it's already between another tag but needs different styling.

  Thanks & Good luck! Zahidul

  Marked as helpful

  1
• 

  kxnzx•870

  @kxnzxPosted about 2 years ago

  @Maylayloo Congratulations with finishing your second challenge. You did a good job!

  I have a suggestion for improvement:

  Your page should contain one <h1></h1>. Instead of <p class="general-information"><span>Victor Crest</span>26</p> do this: <h1 class="general-information"><span>Victor Crest</span>26</h1>

  Having an h1 on your page is very important for search engines, screen readers, SEO and people with visual visual impairment to know what your page is about. You always need one h1 in your page. Then (when needed) you follow it up with subheadings such as an h2, h3, h4 etc. It’s the hierarchy that matters. Just remember that the most important title on the page is an <h1></h1>.

  Marked as helpful

  1

  ---

  

  Zahidul Islam•20

  @zahid3d29Posted about 2 years ago

  @kxnzx You tell truth, but it's a card, not a full page. Only one h1 tag needs a full page for SEO. So, I think it needs an h4 or h5 tag for that content you mentioned. Because of the size of the content and it's not the main heading.

  Marked as helpful

  1