Profile Component

Community feedback

• 

  Abdul•8,540

  @SamadeenPosted over 2 years ago

  Hey!! Cheers 🥂 on completing this challenge.. .

  Here are my suggestions..

  • You should use <main class="screen"> instead of <div class="screen">.

  This should fix most of your accessibility issues

  • You should also use margin-left to space out the 80k Followers 803 likes and 1.4 photos

  . Regardless you did amazing... hope you find this useful... Happy coding!!!

  Marked as helpful

  1

  ---

  

  Acme Gamers•295

  @AcmeGamersPosted over 2 years ago

  @Samadeen I nearly forgot about main's existence as an element owo;;

  Also notes to update margin-left for the repo, and really thanks tbh, it was a lot helpful as well ^^

  0
• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hi, Acme! 👋

  Nice work on this challenge! 👍 It's great that you were able to take care of those circles! 👏

  However, I think two things could be improved.

  • Firstly, I recommend moving all the inline styling to external styling. It's recommended to practice this habit as soon as possible because the larger projects, can cause specificity issues.
  • Secondly, for the column element, I suggest changing it to ul and wrapping each item with li because if the site has no styling, it would more likely be a list.
    • 80K followers
    • 803K likes
    • 1.4K photos

  Overall great work. Your solution is responsive and looks great! However, you need to start avoiding writing inline styling. This way, in the future you are already used to doing the good practice.

  Keep up the great work! 👍

  Marked as helpful

  1

  ---

  

  Acme Gamers•295

  @AcmeGamersPosted over 2 years ago

  Woah, those are some useful ideas tbh :O

  Got it :D, really thanks for the recommendation @vanzasetia!

  I will work on your suggestions ^^

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  @AcmeGamers You're welcome, Acme! 👍

  1