Profile Card

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted almost 4 years ago

  Hey, really nice job here!

  You've done especially well to match the design so closely 👍

  One html point to wathh out for - make sure you never have text outside of a semantic text tag like a <p> or heading tag. It can still be in a span, but needs to be nested inside a meaningful element.

  Great work here, I look forward to seeing your next solution!

  1

  ---

  

  T

  Grace•31,270

  @grace-snowPosted almost 4 years ago

  Actually, I have another suggestion after looking at your css.

  Although sass can be nested, there has to be a good reason to do that. The way you've done it at the moment results in really high specificity css - that's not something you'll want to do. In bigger projects in particular it will make it very hard for you to override styles on different elements. Try to keep specificity as low as possible by keeping every css selector a single un-nested class.

  Hope thats understandable and helpful advice

  1

  

  Web Frog•1,840

  @MasterDev333Posted almost 4 years ago

  @grace-snow Thanks for your advice. It's very helpful. :) Have a great day~

  1
• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hey, Front-end Master! 👋

  Great job on this challenge! 👍

  I thought the way you used pseudo-elements to place and position the background SVGs was quite interesting! Those SVGs can be a little tricky to place in this challenge, but you've done a good job in making sure yours stay in place when the page is resized. 😉

  Keep coding (and happy coding, too)! 😁

  0

  ---

  

  Ayoub1Dev•195

  @Ayoub1devPosted almost 4 years ago

  I have just finished the challenge, and , you know what, ive got the same lines of code as use using pure HTML & CSS. :)

  0