Profile card with Flexbox

Community feedback

• 

  P

  Noemi Gali•280

  @NomiDomiPosted almost 3 years ago

  Hey @lucasweidas,

  You did an amazing job on this one! :) Good use of custom variables and the different type of units.

  I would encourage you to add also the font sizes and paddings in the :root selector for even cleaner code.

  Html wise, best practice is to use kebab case on all class names. I saw that some of your classes are named social__number whereas best would be to be written like social-number.

  I would also argue that you can rewrite this:

  <div class="social-info">
            <p class="social__number">80K</p>
            <p class="social__title">Followers</p>
  </div>
  

  like this

  <div class="social-info">
            <p class="number">80K</p>
            <p class="title">Followers</p>
  </div>
  

  It keeps your class names smaller and in big projects this can be very handy. :)

  Hope this helps! Keep on coding! :)

  Marked as helpful

  1
• 

  Byron•2,290

  @byronbyronPosted almost 3 years ago

  Looks really good!

  I found the background quite tricky to do, you've done a nice job with it 👍

  Marked as helpful

  1