Profile Card with BEM & SASS

Community feedback

• 

  Adler G Luders•1,580

  @just-a-devguyPosted almost 4 years ago

  Hi Samyr, Overall, I think you did pretty well with this. My suggestion would be to try to keep the card centered at all times by using something like flex or margin auto or something. I also think, maybe try to focus on the overflow of elements. The body seems to be taller than the amount of contents it had in there. Also regarding mobile first, I think that would help with what I first mentioned. Had it been mobile first, you would simply have to adjust the positioning of the background patterns while keeping the card in the center of the page. Let me know if what I say makes sense or if you have any questions.

  1

  ---

  

  Samyr Oliveira Ribeiro•215

  @SamyrORPosted almost 4 years ago

  Hello @adluders, thanks a lot for the help, its make all sense! I imagine using something to keep the card aways in center, but i can't concept, and the style guides require 375px and 1440px only to be responsive, now i'm looking for mobile first to develop next challenges more responsives, happy new year bro!

  1

  

  Adler G Luders•1,580

  @just-a-devguyPosted almost 4 years ago

  @SamyrOR of course! Glad it could help. Happy New year to you as well. Best of luck!

  0