Design comparison
SolutionDesign
Solution retrospective
Learning a lot from this one! Three major points to improve on:
- Dealing with block sizes. How to remove extra spacing to move text upward?
- How to draw horizontal line with <hr>?
- Is this the best way to position the background svgs?
Appreciate any feedback and tips on these topics or any other!
Community feedback
- @RioCantrePosted almost 3 years ago
Hello there! Nice work with this one. Viewing at your solution, I would suggest the following for you...
- Remove
height: 360px;
in.profile-card
rule set - Add
position: relative;
andtop: -1rem;
in the.profile-name
rule set - Add
position: relative;
,top: -0.1rem;
andfont-size: 16px;
in.profile-location
rule set - In
hr.solid
, replaceborder-top: 3px solid #bbb;
intoborder: 0.5px solid #bbb;
and addwidth: 100%;
andmargin-top: 1.5rem;
- Add
margin: 0;
andfont-size: 14px;
in.info p
rule set - Adjust padding into
padding: 1.2rem 1.5rem;
in.info
rule set
Overall, you did well. Hope this helps and Keep it up!
Marked as helpful1@victoralbenorPosted almost 3 years ago@RioCantre That helped a lot! Now I just need to add some shadows and figure out why is there so much space between the location and the <hr>
1 - Remove
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord