Design comparison
Solution retrospective
please kindly leave any comments! :)
Community feedback
- @FluffyKasPosted about 3 years ago
Hey, it's a very good looking solution, but you seem to use roles incorrectly. I don't want to give you bad advice as I'm not an accessibility expert but the first thing you could do is to use semantic html tags like header, footer, main. I don't really use roles in my code (which may be a mistake, to be honest, I just try to be as semantic with my markup as I can) but as far as I know roles are not abstract things you could just come up with, like "profile photo", "city". There are existing, valid aria roles you can choose from. Take a look at the accessibility report though, usually there are helpful hints on how to solve these issues.
0@notanutPosted about 3 years ago@FluffyKas thanks! I was confused about the role things. Looks like I'm gonna change it in my 3rd attempt. thank you for your kind words!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord