Design comparison
SolutionDesign
Solution retrospective
HTML and CSS are even though basics, this project gave a good insight into flexbox and image positioning.
Community feedback
- @0xabdulkhaliqPosted 11 months ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
BACKGROUND iMAGE 📸:
- Looks like the background images has not been properly set yet, they are misplaced due to the usage of individual
img
elements. Actually there's an easy way to handle this problem with positioning the background images
- So let me share my css snippet which helps you to easily apply the
background color
with thebackground svg
they provided to place perfectly as same as design.
- Add the following style rule to your css, after completing these steps you can experience the changes.
body { background: url(./images/bg-pattern-top.svg), url(./images/bg-pattern-bottom.svg); background-position: right 52vw bottom 35vh, left 48vw top 52vh; background-repeat: no-repeat, no-repeat; background-color: hsl(185deg, 75%, 39%); }
- Now you can remove these individual
img
elements from thehtml
<img class="img1" src="images/bg-pattern-top.svg" alt=""> <img class="img2" src="images/bg-pattern-bottom.svg" alt="">
- Tip, Don't forget to generate a new screenshot after editing the
css
file
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
0@saicharan293Posted 11 months agoThank you @0xAbdulKhalid, your suggestion and your code snippets made my job easy. I tried to set up the background image, and came up with my best , your snippet helped me for the completion of the challenge.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord