Vanza Setia• 27,795
@vanzasetia
Posted
👋Hi Vishakha Roy!
I have some feedback on this solution:
- Heading order is important.
- Every page needs one heading one. But, in this case you don't have to since it's just a component or you may want to add a hidden
h1
. - I recommend to change the
h3
withh2
. - Also for the stats, I recommend to use
ul
and wrap each stats withli
. - The number stats should not be a heading. I recommend to use
strong
tag instead. - Wrap all page content with
main
tag. It is important for all page content to live inside the landmark. - The person image is important, so I recommend to use his name as the
alt
value. - For the
background-position
, I would recommend to see ApplePieGiraffe solution.
That's it! Hopefully this is helpful!
Marked as helpful
0