Design comparison
Solution retrospective
I would like to know if there is anything wrong or any improvement I can add to my code
Community feedback
- @iamjmitchPosted almost 4 years ago
Nice work!
Having a look at your code, I've noticed you use br tags a lot to vertically separate your span tags. While you can do this, I'd recommend playing around with using padding/margin in your CSS to create this gap as you will be able to customize the spacing a lot easier. You might have to set your span tags to width:100% for it to push the next item onto the next line.
2@ZakariaJounirPosted almost 4 years ago@iamjmitch I didn't know that Thanks for the advice š
0 - @antoineramePosted almost 4 years ago
Good job ! Don't forget to respect the color and the size of the text To improve, I think you should use flexbox to center an element instead of position: fixed; Use display: flex; justify-content: center; and align-items: center; in the parent element. Good luck !
1@ZakariaJounirPosted almost 4 years ago@antoinerame Thanks a lot for your feedback i'll make sure I'll work on that š
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord