Profile Card Solution

Community feedback

• 

  Raymart Pamplona•16,100

  @pikapikamartPosted about 3 years ago

  Hey, awesome work on this one. Layout in general looks good.

  Some suggestions would be:

  • Instead of using role="main", just explicitly use the main element so that the structuring would be more clear, though it works just fine, but if there are elements to a specific component, just use that element instead of customizing other.
  • Don't style the html element, you don't typically add styling to the html except for like font-size and box-sizing. All those stylings should be applied on the body tag.
  • Also, avoid using height: 100vh as this limits your content's height based on the remaining viewport/screen's height. Instead replace it with min-height: 100vh, this takes full viewport and expand if it needs to.
  • The alt for the person's image should be the name of that person alt="Victor Crest", always use a person's name if their image and name are present.
  • For the stats, since those are "list" of information, it would be great to use ul.
  • Those text in the stats shouldn't be a heading tag since a number like 80k doesn't really add any content at all and should not use heading tag.
  • Avoid using multiple h1 on a webpage, only use at least 1 h1 per page.

  Aside from those, really great job on this one.

  Marked as helpful

  0
• 

  P

  Fluffy Kas•7,715

  @FluffyKasPosted about 3 years ago

  Hey, it's a very good solution! Only thing I'd add, perhaps you could experiment with relative units like rem, em, etc next time instead of px ^^

  Marked as helpful

  0