Skip to content
Submitted over 3 years ago

Profile Card Site with Pure HTML and CSS

Adedamola Shittu•75
@DammyShittu
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Profile card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

This is my first submission. Reviews will be highly appreciated.

Community feedback

  • Fraser Watt•1,790
    @fraserwatPosted over 3 years ago

    With the background, I'd keep it static by using the background-image attribute, then working out the positioning based on that.

    I'd also use the shadow-box attribute to get the design looking more like the original.

    Looks great though - keep it up! 😎

    0
    Adedamola Shittu•75
    @DammyShittuPosted over 3 years ago

    Thanks, @fraserwat.

    0
  • Victor Polouchine•0
    @VictorPolouchinePosted over 3 years ago

    Hey ! You did well there 😊 Be careful with your indentation, it would really help you (and the people you collaborate with) to have a well indented code that instantly shows parent and child nodes. There are also minor typos (missing closing tag on line 27 index.html) that you may easily fix 😁 Your css could be a bit more structured also, don't hesitate to add "headlines comments" like /***** DEFAULTS /, /* NAVIGATION *******/, and group selectors (h3 can be right above h3 span) to make them easier to find ! Keep going ! 💪

    0
    Adedamola Shittu•75
    @DammyShittuPosted over 3 years ago

    Thank you so much @VictorPolouchine. I would work on all these.

    0
  • Marko Nikolajević•1,065
    @MarkoNikolajevicPosted over 3 years ago

    Hi Adedamola! As your first time you did a really good work!

    Looking at your code I've some suggestions for you

    • <section id="details" is missing the closing >
    • you can add the lang attribute on the html tag like <html lang="en">

    For the rest, your code is clear and understandable! Good job!

    Keep on coding

    0
    Adedamola Shittu•75
    @DammyShittuPosted over 3 years ago

    Thank you for taking time out to check @MarkoNikolajevic. I'll fix the issues mentioned above right away.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord