Submitted over 1 year ago
Profile Card Remasterd (MUHAMMAD ALI VERSION) Using Html & Css : - )
@0xabdul
Design comparison
SolutionDesign
Solution retrospective
Hi Front End mentor members i just try the profile card with The Legent (MUHAMMAD ALI VERSION)
- would you like the profile card please comment on this project : - )
Community feedback
- @visualdennissPosted over 1 year ago
Hi,
nice custom redesign! Image seems to be distorted, i'd suggest using object-fit: cover; and position it manually if needed.
Hope this is helpful!
Marked as helpful1 - @0xabdulkhaliqPosted over 1 year ago
Assalamu Alaikum warahmatullahi wabarakatuh brother π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
MIN-HEIGHT π:
- Use
min-height: 100vh
forbody
instead ofheight: 100vh
. Setting theheight: 100vh
may result in the component being cut off on smaller screens.
- For example; if we set
height: 100vh
then thebody
will have100vh
height no matter what. Even if the content spans more than100vh
.
- But if we set
min-height: 100vh
then thebody
will start at100vh
, if the content pushes thebody
beyond100vh
it will continue growing. However if you have content that takes less than100vh
it will still take100vh
in space.
PS π€ :
- Mass'ah iruku maamey..π₯
.
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord