Profile Card

Community feedback

• 

  Carlos Martinez•310

  @curlosPosted over 2 years ago

  Hi Max, nice project. Overall it looks pretty good and accurate to the design. Here are my thoughts on the project:

  • Does the solution include semantic HTML?
    • Your code doesn't really include any semantic HTML as it seems to only contain divs. For a simple project like this, the main one you could add are the heading tags like an h1 or h2 tag for the 'Victor Crest' name and stat numbers: "80K", "803K", and "1.4K".
  • Is it accessible, and what improvements could be made?
    • The project is accessible on mobile, tablet, and desktop screens. Some improvements that could be made (though very minor) are adding a box shadow to the card element since the original design had it and moving the circles slightly farther away from the middle of the card element (the left circle should be moved slightly to the left and the right circle moved slightly to the right).
  • Does the layout look good on a range of screen sizes?
    • It looks good on every screen as far as I can tell. A minor improvement that could be made is to make the max height the size of the screen so the scroll bar is removed. With this project, a scrollbar wouldn't be necessary unless the height of the screen is changed to something dramatically small. Also the footer at the bottom that says "Challenge by Frontend Mentor. Coded by Max Kaiser." should have either some margin-bottom or padding-bottom added to it as it sticks to the bottom of the screen currently and is practically unnoticeable on most certain screen sizes.
  • Is the code well-structured, readable, and reusable?
    • Your code is well structured and the CSS class names are very clear.

  Anyways, there are just a couple of minor things to fix but you did a great job on this project Max! 👏👏👏

  Marked as helpful

  0

  ---

  

  Max Kaiser•300

  @maxkaiser100Posted over 2 years ago

  @curlos Hey - I REALLY appreciate this thorough feedback! Thank you. I'll get moving on making those changes. Appreciate it.

  1