Profile card - HTML - CSS

Community feedback

• 

  Lucas 👾•104,220

  @correlucasPosted over 2 years ago

  👾Hello Kemcy, congratulations for your new solution!

  I like the work you’ve done here, your solution is almost complete. I’ve some suggestion for you to improve the code/design:

  1.Use <main> instead of <div> to wrap the card container. This way you show that this is the main block of content and also replace the div with a semantic tag.

  2.Use units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.

  3.To place these two svg circles as background(top/bottom) using background-image , the best way is by using background-image to manage it since adding them to the body you make sure it will be under everything, to manage multiple images inside a single css property as background-image you will use the comma inside each properties declare the single modification for each circle separated. See the code below to see your solution with those backgrounds applied:

  body {
      background-color: hsl(185deg, 75%, 39%);
      background-image: url(./images/bg-pattern-top.svg), url(./images/bg-pattern-bottom.svg);
      background-repeat: no-repeat, no-repeat;
      background-position: top -500px left -400px, bottom -700px right -250px;
      font-family: 'Kumbh Sans', sans-serif;
      /* background-color: hsl(185, 75%, 39%); */
      display: flex;
      flex-direction: column;
      justify-content: center;
      align-items: center;
      min-height: 100vh;
  }
  

  ✌️ I hope this helps you and happy coding!

  0