Profile Card- HTML, CSS

Community feedback

• 

  Timothy•285

  @Timothy1982Posted almost 4 years ago

  This one looks good but i would have a few small improvements from just looking over it fast.

  • I would change the height of 100vh on the body to min-height because if i look at it on my phone in landscape it gets cuts off.

  • I would set the two big background images with ::before and ::after inside on the .container and include the SVG.

  • Maybe give the card a little space on mobile. On a with of 320px its a little tight. ;)

  But that might just be my opinion.

  2
• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hi, Ome-yei! 👋

  Congratulations on completing your first Frontend Mentor challenge! 🎉 Well done on this one! 👍

  I think following Timothy1982's helpful tips will definitely help improve your solution. You could also consider looking into using CSS background images to add and position the background images. It's another alternative that might work quite well for you (but using pseudo-elements isn't a bad idea, either). 😉

  Also, you could use an <article> tag for the card component since it's a self-contained element that makes sense by itself. Doing so will make your HTML a little more semantic, which is good for things like SEO and accessibility. 😀

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Ome-yei•10

  @Ome-yeiPosted over 3 years ago

  Thank you for the feedback!

  0