Profile Card HTML CSS

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  BACKGROUND iMAGE 📸:

  • Looks like you setted those background images using img element. This causes overflow and it misplaces the image also, So let me explain how you can easily apply the background color with the background svg they provided.

  ---

  • Add the following style rule to your css, and then remove the img tags from your html after completing these steps you can experience the changes

  body {
    background: url(./images/bg-pattern-top.svg), url(./images/bg-pattern-bottom.svg);
    background-position: right 52vw bottom 35vh, left 48vw top 52vh;
    background-repeat: no-repeat, no-repeat;
    background-color: hsl(185deg, 75%, 39%);
  }
  

  ---

  • Now remove these elements, after removing you can able to see the changes

  <img class="top--bg" src="/images/bg-pattern-top.svg" alt="BG">
  <img class="bottom--bg" src="/images/bg-pattern-bottom.svg">
  

  ---

  ---

  • Now the background has been properly placed

  ---

  • Tip, Don't forget to generate a new screenshot after editing the css file

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0