Profile Card (HTLM, CSS)

Community feedback

• 

  Samyr Oliveira Ribeiro•215

  @SamyrORPosted almost 4 years ago

  Hello @l-laino, its look good at all, but somethings a think can be better, for best pratices you could put all colors that you will use, on variables of css, putting this on :root {}, this help in the maintence of the code (possible to put common sizes too and other things), matching all colors with the recived style guide , and for the bottom status under the numbers, you could space it with "letter-spacing" property.

  At the mobile, i would add more margin on top to center the card, and match the font-sizes to better view with media queries.

  The Mobile First aprochion, is a thing that i'm learning and loving it, you can code the entire site to mobile, and then with media queries just scale, this is much more easier, confortable than just try to make it fit on mobile, you could give a try, and look for mobile first.

  I expect that i have helped in something.

  2

  ---

  

  Lucas Laino•70

  @l-lainoPosted almost 4 years ago

  Thank you very much! I think I'll do this challenge again in a week or two when I have more knowledge about this. I don't know yet how to do this but I'll keep it for when I understand more.

  2
• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hello there, Lucas Laino! 👋

  I just wanted to say, congratulations on completing your first Frontend Mentor challenge! 🎉 Well done on this one! 👍

  Simply follow the helpful suggestions given above, and I think you'll be good to go! 👍

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Lucas Laino•70

  @l-lainoPosted almost 4 years ago

  @ApplePieGiraffe Thank you! I liked your name btw 😄

  1
• 

  Abhik•4,840

  @abhik-bPosted almost 4 years ago

  Hi Lucas, You have done a great job on this challenge , background circles are responsive and your card looks cool!

  I guess if you reduce the font-size a bit and try mobile first approach (which I'm told is the industry best practice) then your solution would have been amazing !!

  Happy coding 😇 and Keep contributing these Great solutions 🚀

  1

  ---

  

  Lucas Laino•70

  @l-lainoPosted almost 4 years ago

  @abhik-b Thank you very much! I'll look into this approach but I think that the course I'm doing will cover some modules ahead. I pretend to come back to this project once I have a little more practice!

  1