Profile Card

Community feedback

• 

  Rayane•1,935

  @RayaneBengaouiPosted over 3 years ago

  Hello Kaiwalya Koparkar,

  Congrats for completing your first challenge ! 😁

  I'd like to suggest :

  • To curve the edges you need to add overflow: hidden to your .container class.

  • Also, I recommend adding a min-width to your card so that the content doesn't get "pressed".

  • You can add min-height : 100vh to your body to make sure that it covers your viewport.

  • Instead of using padding to put your card in the center, you could just using justify-content : center and align-item: center as your body is already set on display: flex.

  • I don't think it's a great idea to use </br> tags to get space in your design. You should define width/height of your components with units such as percentages/rem/rem/etc... then playing with grid/flex/position properties to place your elements.

  • Try to take a look about semantic HTML tags such as main, section, etc.. to make your code more descriptive.

  • Get rid of the default padding/margin with *{margin : 0; padding:0;} also you might take a look at box-sizing : border-box and understand how the box model works under the hood.

  Overall, well done for the challenge and happy coding ! 😃

  1

  ---

  Account deleted

  Some very valuable advice here, thanks for breaking down why you should and shouldn't do things, it's certainly helped evaluate some of my own code for this project - thanks!

  And to OP, well done for doing the challenge!

  1

  

  Rayane•1,935

  @RayaneBengaouiPosted over 3 years ago

  @ItsCharAtkinson Thank you ! Hope to see your version of the challenge 🙂

  Have a nice day ! ☀️

  0
• 

  Kaiwalya Koparkar•40

  @kaiwalyakoparkarPosted over 3 years ago

  Thank you very very much. I really need the review as this is my first time building something from scratch

  0

  ---

  

  Rayane•1,935

  @RayaneBengaouiPosted over 3 years ago

  @kaiwalyakoparkar Your welcome ! I also strongly recommend you to look at other people's code to see how they tackled this challenge. You will always get a lot of inspiration and see different methods.

  Good luck on your next challenge ! 🙂

  0