Design comparison
Solution retrospective
Hey all!
I had a lot of fun trying some new things with this challenge, but overall felt like I overthought it too much. Particularly with trying to adjust the font size to match using css variables on the body, and getting the background images to align with the solution images in both desktop and mobile. Any review/feedback would be very much appreciated!
Community feedback
- @renatomagnusPosted almost 2 years ago
On HTML, always fill the "alt" element on img tags, accessibility is important.
Your repository could be more organized if you use more files and folders, except for the index.html and readme.md (and the git files). Could be something like that: src | ---Images ---CSS Inside of CSS folder, you could do 3 files, reset.css, variables.css and style.css, that way it would be easier to read the CSS code.
Congratulations for your project, the results are awesome!
Marked as helpful0@ag7621Posted almost 2 years ago@rmagnusr Thank you for reviewing my project!
I knew I was forgetting to do something on my challenge. I will definitely add in the alt tags for accessibility.
Thank you for the tips on managing repositories. It's one thing I haven't looked into much but definitely makes a lot of sense. I know looking over my own css is troublesome having to scroll to see my variables and such, and separating them into their own files sounds like a great solution.
Thanks again!
1
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord