Profile Card Component Using CSS Position and Flexbox
Design comparison
Solution retrospective
Hello,
The techniques I used for this challenge are CSS position and flexbox.
May I ask if there is anything I can improve?
I appreciate your feedback. Thank you in advance
Community feedback
- @VCaramesPosted about 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- It is best practice to use, classes for your naming convention as classes are reusable, making them ideal for CSS styling. IDs on the other hand, are not reusable and are mainly used for JavaScript.
- The profile card’s background is decorative, it does not add any value. So its Alt Tag should be left blank and have an aria-hidden=“true” to hides them from assistive technology.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
- The profile images Alt Tags need to be improved. It should state the following; “Headshot of -person’s full name-“
- The statistics are a list. They need be created using the Unordered List along with the List Element.
More Info:📚
MDN <ul>: The Unordered List element
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
Marked as helpful0@toshihikotaniPosted about 2 years agoHello @vcarames,
This is very helpful. I will take note of this and try to implement it to this challenge or the other challenges. Thank you very much.
Happy Coding! :)
1 - @catherineisonlinePosted about 2 years ago
Looks nice !
0@toshihikotaniPosted about 2 years ago@catherineisonline Thank you very much! 🙂
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord