Profile card component

Community feedback

• 

  T

  Grace•31,230

  @grace-snowPosted almost 4 years ago

  Hi,

  There's a lot of excessive scroll on mobile. That overflow should be hidden. Just make sure it still works on mobile landscape after fixing that.

  Also, try to add the shadow like on the design.

  The really big issue with this though is you've not used semantic html. Text cannot only be in a div or span, it needs to be wrapped in meaningful html elements (with spans inside of needed) like headings, paragraphs or list items. This is really important so definitely needs addressing.

  Looking at css, you seem to be setting position absolute on a lot more than you need to. At most I would expect it on the background images if they are in the html (they would probably be better as bg images) and maybe the profile image, but nothing else. You are making everything a lot harder for yourself by using position absolute... I also notice repeating declarations in css for the stats at the bottom. You could do that with one class, no need to have followers likes etc as their own classes. Overall, just go through the css and see if you can refine things like that and avoid repetition or declaring things if they don't need it.

  I hope this is helpful advice. Keep going with your coding, you're on the way ☺

  1

  ---

  

  JaJamaRu•130

  @JaJamaRu14Posted over 3 years ago

  @grace-snow Thank you very much for you advice! I tried to take your advice in very carefully for my second challenge! Very helpful advice!

  0
• 

  Minhajul Karim•10

  @minhajul-karimPosted almost 4 years ago

  Hello, JaJamaRu. Nice work! One thing I've noticed that the background circles do not seem to be in the correct place according to the design. Please have a look.

  0

  ---

  

  JaJamaRu•130

  @JaJamaRu14Posted almost 4 years ago

  @minhajul-karim Thank you very much for your feedback! I have fixed the background issue and updated my solution.

  0