Profile Portfolio (Not Responsive)

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hi @LegendCoder20 👋, good job completing this challenge, and welcome to the Frontend Mentor Community! 🎉

  I have some suggestions you might consider to improve your code:

  • For specificity reasons you should work better with classes since they are reusable, and you can leave the ID when you work with Javascript.

  • Wrap "square-border" and "f-l-p" in a <main> element and use that element to center it on the screen, instead of having two divs with position: absolute

  • The container isn't centered correctly. You can use flexbox or grid layout to center elements. You can read more about centering in CSS here.

  • Instead of using <img>, you could use the CSS backgrounds properties to set the background:

  body {
      . . .
      min-height: 100vh;
      background-color: hsl(185, 75%, 39%);
      background-image: url(./bg-pattern-top.svg), url(./bg-pattern-bottom.svg);
      background-repeat: no-repeat, no-repeat;
      background-position: right 52vw bottom 35vh, left 48vw top 52vh;
  }
  

  • background-color Set the background color
  • background-image Set a background image
  • background-repeat Sets if a background image will be repeated along the horizontal and vertical axes, or not repeated at all.
  • background-position Sets the starting position of a background image. More information
  • You can also specify the size of the background image with background-size

  The background property is shorthand for all the properties mentioned above but for now. It is better to understand them separately.

  The background-position for me worked with the vw (viewport width) and vh (viewport height) units, but you can also use percentages. It's just a matter of trial and error to place them as you wish.

  References:

  1. CSS background Property
  2. Background property
  3. Background-repeat (MDN)

  I hope those tips will help you! 👍

  Good job, and happy coding! 😁

  Marked as helpful

  0

  ---

  

  CS_Legend 💻•80

  @LegendCoder20Posted almost 2 years ago

  @MelvinAguilar Thankyou for Helping me out

  0