Profile Card Component With Sass

Community feedback

• 

  T

  Alex•2,010

  @AlexKMarshallPosted about 3 years ago

  Hey, good attempt, visually it looks correct, and it's nicely responsive at small screen sizes.

  There's a small problem with the HTML semantics. The statistics at the bottom of the card should be an unordered list. While the bold numbers look like they might be headings, they shouldn't really be. Imagine reading a table of contents for a book, the headings are the chapter titles. So a title of 80k doesn't make sense on its own.

  Take care with the heading levels too. This is currently the only thing on the page, so the main heading should be an h1. In reality this would be a small component on a much larger page, so it would get a different heading level in that case. Just be aware of the context that the component is used and choose the right level, never skipping numbers.

  Finally, avoid committing commented out code. Git will remember code from previous commits so you'll always have a history to be able to undo any changes if you need to. Leaving in commented code just makes it more difficult for you to read through later.

  Marked as helpful

  0

  ---

  

  rluna15•60

  @rluna15Posted about 3 years ago

  @AlexKMarshall Thanks a lot for the feedback.

  0